Skip to content

Conversation

@simon04
Copy link
Contributor

@simon04 simon04 commented Jan 10, 2023

Regression of #1293.

Fixes #1910.

Closes #1911.

@simon04 simon04 requested a review from a team as a code owner January 10, 2023 18:44
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Everything works fine locally and the code makes sense. I'll merge it now so we can see if it works in prod.

@ojeytonwilliams ojeytonwilliams merged commit 08147e3 into main Jan 11, 2023
@simon04 simon04 deleted the fix-manifest-db_size branch January 6, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Offline size shown as "NaN MB"

3 participants