Skip to content
This repository was archived by the owner on Apr 1, 2021. It is now read-only.

Article Algorithms-Selection-Sort.md - #1082

Merged
6 commits merged into
freeCodeCamp:masterfrom
varunu28:master
Jun 8, 2016
Merged

Article Algorithms-Selection-Sort.md#1082
6 commits merged into
freeCodeCamp:masterfrom
varunu28:master

Conversation

@varunu28

@varunu28 varunu28 commented Jun 3, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@varunu28

varunu28 commented Jun 3, 2016

Copy link
Copy Markdown
Contributor Author

@alayek Let me know if we need to provide the implementation in any other programming language?
Also can we put up a video link of 5-7 minutes explaining the sort algorithm?

Comment thread Algorithms-Selection-Sort.md Outdated
@@ -0,0 +1,48 @@
# Algorithm Selection Sort

The selection sort algorithm sorts an array by repeatedly finding the minimum element (considering ascending order) from unsorted part and putting it at the beginning. The algorithm maintains two subarrays in a given array.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from unsorted part from the unsorted part

@varunu28

varunu28 commented Jun 3, 2016

Copy link
Copy Markdown
Contributor Author

@atjonathan Implemented the changes. Please check

@ghost

ghost commented Jun 3, 2016

Copy link
Copy Markdown

@koustuvsinha, @alayek what do you think?

@varunu28

varunu28 commented Jun 4, 2016

Copy link
Copy Markdown
Contributor Author

@alayek Please look into this PR and let me know if anything needs to be added

Comment thread Algorithms-Selection-Sort.md Outdated
# Algorithm Selection Sort

The selection sort algorithm sorts an array by repeatedly finding the minimum element (considering ascending order) from the unsorted part and putting it at the beginning. The algorithm maintains two subarrays in a given array.
1) The subarray which is already sorted.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to makrdown list.
1.
2.

@crashuniverse

crashuniverse commented Jun 5, 2016

Copy link
Copy Markdown

@varunu28 PRs need to have squashed commits. Point 6 on https://github.com/FreeCodeCamp/FreeCodeCamp/blob/staging/CONTRIBUTING.md#contribution-guidelines.

I understand that github provides a way to merge the PR with squashed commits however it would be good to see contributors taking care of it too.

@Rafase282

Rafase282 commented Jun 5, 2016

Copy link
Copy Markdown
Member

@varunu28 @crashuniverse this is our squashing guide.

@varunu28

varunu28 commented Jun 6, 2016

Copy link
Copy Markdown
Contributor Author

@Rafase282 Should I squash the commits?

@Rafase282

Copy link
Copy Markdown
Member

Yes, it is always good to squash them. Many new contributors have problems with this part and since we acquired the ability to squash from here we have let up on asking people to do it a bit.

@ghost

ghost commented Jun 8, 2016

Copy link
Copy Markdown

I'm going to squash these in the browser. Thanks for contributing ✨

@ghost
ghost merged commit 07f5e5a into freeCodeCamp:master Jun 8, 2016
@BerkeleyTrue BerkeleyTrue removed the QA label Jun 8, 2016
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants