build: wrap build-kernel-wrapper in script#39
Merged
zenmonkeykstop merged 1 commit intomainfrom Sep 21, 2023
Merged
Conversation
cfm
force-pushed
the
use-script-wrapper
branch
2 times, most recently
from
e09218e to
b9f428c
Compare
After freedomofpress/securedrop#6787 and following.
cfm
force-pushed
the
use-script-wrapper
branch
from
b9f428c to
7f5085b
Compare
zenmonkeykstop
approved these changes
Sep 21, 2023
Contributor
zenmonkeykstop
left a comment
zenmonkeykstop
left a comment
There was a problem hiding this comment.
TEst plan checks out, LGTM
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like freedomofpress/securedrop#6787, wraps the existing wrapper script in
scriptso that the build log (transcript) is saved automatically.Checklist
I'll test this in the course of freedomofpress/securedrop#6938 and freedomofpress/securedrop-workstation#916. For formal review:
make {vanilla,grsec,securedrop-core-5.15,securedrop-workstation-5.15}succeed and produce the expected build logs inbuild/.