Conversation
I set `CONFIG_EXFAT_FS=m` and then ran `make olddefconfig`, which set the charset value. Refs <freedomofpress/securedrop-workstation#1267>.
Member
Author
|
I'm building kernels with this right now; once we've verified this is sufficient for loading an exfat drive we can merge it. |
legoktm
added a commit
to freedomofpress/securedrop-apt-test
that referenced
this pull request
Mar 19, 2025
Build metadata: * freedomofpress/build-logs@bc810df * freedomofpress/build-logs@11c42ab Notably the workstation kernel was built with <freedomofpress/kernel-builder#60> to add exfat support.
4 tasks
Member
Author
|
I tested this and the built workstation kernel successfully mounted an exFAT drive. Ready for review! |
rocodes
approved these changes
Mar 24, 2025
Contributor
rocodes
left a comment
rocodes
left a comment
There was a problem hiding this comment.
Approving based on:
- Visual review (config), External documentation
- Successful kernel build and confirmed desired behaviour per freedomofpress/securedrop-workstation#1267
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs freedomofpress/securedrop-workstation#1267.
Two changes:
make olddefconfigfor workstation with Linux 6.6.83. This just sets the defaults of the new kernel flags in our config file.CONFIG_EXFAT_FS=mand then ranmake olddefconfig, which set the charset value.