Conversation
legoktm
requested changes
Mar 24, 2025
Member
legoktm
left a comment
legoktm
left a comment
There was a problem hiding this comment.
Thanks, I'm not sure how we never had this... - one small thing noted inline.
Luckily the sha256 hashes are still in the buildinfo files, but it'll be good to have them in the build log too.
rocodes
force-pushed
the
include-checksums-in-buildlog
branch
from
9550802 to
f4b328a
Compare
legoktm
approved these changes
Mar 24, 2025
Member
legoktm
left a comment
legoktm
left a comment
There was a problem hiding this comment.
LGTM after checking the CI log - thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewing https://github.com/freedomofpress/securedrop-apt-prod/pull/166 I noticed that we don't include artifact checksums in the build log captured by
script, so include sha256sums for the .deb, the .orig.tar.gz, and the .buildinfo file in the build logs.Test plan