Skip to content

fix: fail if grsecurity-urls.py returns nonzero#64

Merged
legoktm merged 1 commit intomainfrom
62-fail-without-grsecurity
May 7, 2025
Merged

fix: fail if grsecurity-urls.py returns nonzero#64
legoktm merged 1 commit intomainfrom
62-fail-without-grsecurity

Conversation

@cfm
Copy link
Member

@cfm cfm commented May 6, 2025

Trivially fixes #62. Further linting deferred to #63 after this lands to unblock freedomofpress/securedrop#7511.

To test:

$ GRSECURITY=1 make core-5.15
[...]
Will include grsecurity patch for kernel 5.15.181
2025-05-06 23:40:42 ERROR    Credentials not found, set GRSECURITY_USERNAME & GRSECURITY_PASSWORD
Traceback (most recent call last):
  File "/usr/local/bin/build-kernel.py", line 180, in <module>
    main()
  File "/usr/local/bin/build-kernel.py", line 56, in main
    subprocess.run(["/usr/local/bin/grsecurity-urls.py"], stdout=f, check=True)
  File "/usr/lib/python3.7/subprocess.py", line 487, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['/usr/local/bin/grsecurity-urls.py']' returned non-zero exit status 1.
Script done.
make: *** [Makefile:49: securedrop-core-5.15] Error 1

@cfm cfm requested a review from legoktm May 6, 2025 23:44
@cfm cfm added this to SecureDrop May 6, 2025
@cfm cfm changed the title fix: fail if "grsecurity-urls.py" returns nonzero fix: fail if grsecurity-urls.py returns nonzero May 6, 2025
@legoktm legoktm merged commit 00384ae into main May 7, 2025
11 of 12 checks passed
@legoktm legoktm deleted the 62-fail-without-grsecurity branch May 7, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

grsecurity download can fail silently

2 participants