Conversation
legoktm
requested changes
May 13, 2025
Member
legoktm
left a comment
legoktm
left a comment
There was a problem hiding this comment.
Yayyy. Comments are minor, primarily that we can rely on /bin/ being a symlink to /usr/bin/ in bookworm, so the old paths are perfectly fine to keep using.
Member
|
After merging we should ask infra to make |
But move to Debian trixie for a newer python3-poetry.
…ded "/tmp" (Ruff S108) I looked at refactoring GrsecurityPatch to use tempfile.TemporaryDirectory() as a context manager, but it's not worth it when we don't really care about guaranteed cleanup inside the container.
Member
Author
|
Thanks, @legoktm! All fixed up. |
legoktm
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63 by: