Conversation
redshiftzero
force-pushed
the
export_to_buster
branch
from
03e7ec4 to
91f2797
Compare
emkll
approved these changes
Nov 22, 2019
Contributor
emkll
left a comment
emkll
left a comment
There was a problem hiding this comment.
thanks @redshiftzero , tested as follows:
- ci is passing
- Package builds and installs under buster (did not do full e2e test yet under buster)
- Package builds, installs and full e2e test is successful in stretch
- visual review of the diff
redshiftzero
force-pushed
the
export_to_buster
branch
from
91f2797 to
1871dfe
Compare
emkll
approved these changes
Nov 22, 2019
Contributor
There was a problem hiding this comment.
Visual diff of 1871dfe and of the changes forced-pushed in
https://github.com/freedomofpress/securedrop-debian-packaging/compare/91f2797..1871dfe
look good to me, approving since they are CI only and CI is passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92
Corresponding securedrop-export buster package in: freedomofpress/securedrop-apt-test#26