Fixes #15 removes our logging plugin for sd-log

[kushaldas]

Status

Ready for review

Description of Changes

This PR removes the sdlog.conf for rsyslog via rc.local file
for the sd-log vm.

Fixes freedomofpress/securedrop-log#15

Testing

• make all
• sd-log vm should not have any error at /var/log/syslog file.
• sd-log vm /rw/config/rc.local file has the following lines:

# Add sd-rsyslog.conf file for syslog
rm -f /etc/rsyslog.d/sdlog.conf
systemctl restart rsyslog

Checklist

If you have made code changes

• Linter (make flake8) passes in the development environment (this box may
  be left unchecked, as flake8 also runs in CI)

If you have made changes to the provisioning logic

• All tests (make test) pass in dom0 of a Qubes install

• This PR adds/removes files, and includes required updates to the packaging
  logic in MANIFEST.in and rpm-build/SPECS/securedrop-workstation-dom0-config.spec

[emkll]

Thanks @kushaldas for the fix, works well for me locally,

• make all
• make test
• sd-log vm should not have any error at /var/log/syslog file.
• sd-log vm /rw/config/rc.local file has the following lines:
• logs are flowing

Prior to merge, I think we should update the comments in sd-log-disable-plugin.sls (see inline comments)

[emkll]

Could we also link to the issue in the comments here? It would be useful to note, for future maintainers, that this is the side effect of using the same package for both the client and server component of the log: we want to make sure that sd-log does not send logs.

[emkll]

we are removing here, no?

[kushaldas]

Yes, I will update the comments.

[emkll]

Thanks @kushaldas, looks good to me!

Noting that you are adding a new file but since it's prefixed by sd, it will be caught by make clean, and since it's in the dom0 folder it is included in MANIFEST.in [1] and dom0 rpm spec [2]

[1]

securedrop-workstation/MANIFEST.in

Line 1 in 76ba862

include dom0/*.sls

[2]

securedrop-workstation/rpm-build/SPECS/securedrop-workstation-dom0-config.spec

Line 57 in 76ba862

install -m 644 dom0/*.sls %{buildroot}/srv/salt/