Add type annotations to source_app #5531
Merged
kushaldas merged 1 commit intofreedomofpress:developfrom Oct 14, 2020
Merged
Conversation
Contributor
|
Heads up, needs rebase, note |
nabla-c0d3
force-pushed
the
type-annotations-source-app
branch
from
271de38 to
b4cd2dc
Compare
nabla-c0d3
force-pushed
the
type-annotations-source-app
branch
from
b4cd2dc to
61bb8bc
Compare
kushaldas
approved these changes
Oct 14, 2020
Contributor
kushaldas
left a comment
kushaldas
left a comment
There was a problem hiding this comment.
Verified the manually, including adding a new function without type annotation.
███ Running mypy type checking...
securedrop/source_app/main.py:347: error: Function is missing a return type annotation
securedrop/source_app/main.py:347: note: Use "-> None" if function does not return a value
Found 1 error in 1 file (checked 105 source files)
make: *** [Makefile:112: typelint] Error 1
This is good, thank you once again 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Ready.
Description of Changes
To help with #4399 , this PR adds and enforces type annotations in the source_app.