Fix 'projects[]' parameter in project.py get_bids function.#13
Fix 'projects[]' parameter in project.py get_bids function.#13chaayac wants to merge 2 commits intofreelancer:masterfrom
Conversation
amitsaha
left a comment
There was a problem hiding this comment.
Can you add/update the test please?
|
test/test_projects.py doesn't need to be updated (it uses a FakeGetBidResponse to validate, so it will never receive the invalid parameter error from the Freelancer API). |
Can you please look at https://requests-mock.readthedocs.io/en/latest/ and see if we can do a better job of testing the API calls that actually get made when we make a request? That will give us better sanity checking. For now, you can just modify the relevant test and later we can roll it out to others. @chaayac https://stackoverflow.com/questions/47723797/assert-body-of-http-requests-using-requests-mock - something similar, in addition matching for the URLs would be useful as well. Can you take a look when you get a chance? |
…the correct parameters).
'project_ids[]' parameter should be 'projects[]' in project.py get_bids function. Fixes issue #11 .