Skip to content

Fix get bids request bug#17

Merged
amitsaha merged 4 commits intofreelancer:masterfrom
gabrnavarro:fix_get_bids_request_bug
Feb 23, 2018
Merged

Fix get bids request bug#17
amitsaha merged 4 commits intofreelancer:masterfrom
gabrnavarro:fix_get_bids_request_bug

Conversation

@gabrnavarro
Copy link
Copy Markdown
Contributor

@gabrnavarro gabrnavarro commented Feb 19, 2018

Fixes #16 , and fixes #11
This PR replaces the project_ids[] parameter in the get_bids() method with the correct parameter name, projects[]. examples/get_bids.py is also fixed to access the bids dictionary correctly.

@amitsaha
Copy link
Copy Markdown
Contributor

Can you please clarify how this is fixing #15 ?

@gabrnavarro
Copy link
Copy Markdown
Contributor Author

@amitsaha, sorry, i made a mistake. This PR doesn't fix #15. I'll submit another PR for that.

@amitsaha
Copy link
Copy Markdown
Contributor

Can you please rebase this so that we have the Travis checks?

@amitsaha amitsaha merged commit 6c269ae into freelancer:master Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trying to run sample to make a new bid get_bids() function passes the project array as project_ids[]

2 participants