Skip to content
Open
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
9a5f54c
Accept poor fast-train training errors. This affords the DTE the opp…
redder86 Jun 4, 2022
cae078c
ITU-T V.250 6.3.1 defines the ATD command. It states: 'Any characters…
redder86 Jun 4, 2022
b4d2874
Prevent multiple CONNECT messages after +FRH=3 which could have been …
redder86 Jun 4, 2022
2949155
Send NO CARRIER message if hangup occurs during data transmit
redder86 Jun 4, 2022
3955808
Send NO CARRIER message if hangup occurs during data transmit (2)
redder86 Jun 4, 2022
f4790de
Correctly address the issue attempted to be fixed by the previous com…
redder86 Jun 4, 2022
cf204c8
This CONNECT message is superfluous. If there is some delay in the DT…
redder86 Jun 4, 2022
a701c59
These changes are a contribution from Robert Boisvert and the Alpine …
redder86 Jun 5, 2022
f5943c7
iaf is treated as a bitmap everywhere else in the code, not a boolean…
redder86 Jun 8, 2022
461bf79
The 3rd octet of the FIF does, indeed, indicate the length of the int…
redder86 Jun 9, 2022
056a9e6
Revert "These changes are a contribution from Robert Boisvert and the…
redder86 Jun 9, 2022
c410e11
Add t30_set_retransmit_capable API function to allow access to retran…
redder86 Jun 10, 2022
becb49f
If retransmit_capable is not enabled then spandsp's behavior followin…
redder86 Jun 10, 2022
2daa783
correction to the previous commit
redder86 Jun 10, 2022
0635d6b
If a terminal problem occurs as a receiver in Phase B such that we'll…
redder86 Jun 13, 2022
472ca5e
This adds HylaFAX+ SSL Fax client support.
redder86 Jul 27, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
The 3rd octet of the FIF does, indeed, indicate the length of the int…
…ernet address/url, however, because pkt includes the FCF byte as the first octet, we find the internet address length in the 4th octet of pkt and not the 3rd.
  • Loading branch information
redder86 committed Jun 9, 2022
commit 461bf7961df7e31f7ff417cef801c3d09fea080a
6 changes: 3 additions & 3 deletions src/t30.c
Original file line number Diff line number Diff line change
Expand Up @@ -6270,7 +6270,7 @@ static void decode_url_msg(t30_state_t *s, char *msg, const uint8_t *pkt, int le
if (msg == NULL)
msg = text;
/*endif*/
if (len < 3 || len > 77 + 3 || len != pkt[2] + 3)
if (len < 4 || len > 77 + 4 || len != pkt[3] + 4)
{
unexpected_frame_length(s, pkt, len);
msg[0] = '\0';
Expand All @@ -6294,8 +6294,8 @@ static void decode_url_msg(t30_state_t *s, char *msg, const uint8_t *pkt, int le
Bit 7 = 1 for more follows, 0 for last packet in the sequence.
Bits 6-0 = length
*/
memcpy(msg, &pkt[3], len - 3);
msg[len - 3] = '\0';
memcpy(msg, &pkt[4], len - 4);
msg[len - 4] = '\0';
span_log(&s->logging, SPAN_LOG_FLOW, "Remote fax gave %s as: %d, %d, \"%s\"\n", t30_frametype(pkt[0]), pkt[0], pkt[1], msg);
}
/*- End of function --------------------------------------------------------*/
Expand Down