Skip to content

Trough fixes#256

Merged
freezy merged 20 commits into
masterfrom
fix/trough
Nov 29, 2020
Merged

Trough fixes#256
freezy merged 20 commits into
masterfrom
fix/trough

Conversation

@freezy
Copy link
Copy Markdown
Owner

@freezy freezy commented Nov 29, 2020

  • Add proper support for opto switches, which have different timing and also have the close status inverted.
  • Fix single ball trough
  • Update documentation

TODO

  • Add jam switch support, because it needs to be inverted for optos.
  • Fix test coverage

@jsm174 or @ecurtz can you review the doc please?

@freezy freezy requested review from ecurtz and jsm174 November 29, 2020 00:14
@freezy freezy self-assigned this Nov 29, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 29, 2020

Codecov Report

Merging #256 (523f5ae) into master (ba59b1f) will increase coverage by 0.03%.
The diff coverage is 86.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   56.76%   56.79%   +0.03%     
==========================================
  Files         159      159              
  Lines        9418     9441      +23     
  Branches      932      937       +5     
==========================================
+ Hits         5346     5362      +16     
- Misses       3848     3850       +2     
- Partials      224      229       +5     
Impacted Files Coverage Δ
VisualPinball.Engine/VPT/Trough/Trough.cs 77.33% <84.00%> (-3.80%) ⬇️
VisualPinball.Engine/VPT/Trough/TroughData.cs 96.29% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba59b1f...523f5ae. Read the comment docs.

@freezy freezy merged commit 3ad3854 into master Nov 29, 2020
@freezy freezy deleted the fix/trough branch November 29, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants