Skip to content

MPF / Add support for dynamic wires#293

Merged
freezy merged 18 commits into
masterfrom
feature/mpf
Mar 17, 2021
Merged

MPF / Add support for dynamic wires#293
freezy merged 18 commits into
masterfrom
feature/mpf

Conversation

@freezy
Copy link
Copy Markdown
Owner

@freezy freezy commented Mar 12, 2021

Dynamic wires, also known as "hardware rules", are wires the gamelogic engine can create or remove during gameplay. It does that by linking a switch to a coil, where both the switch and the coil must be mapped through the switch manager and the coil manager respectively.

The first gamelogic engine to make use of this is MPF. The goal is to eliminate latency between the switch and the coil, which would otherwise result by processing switch events through software, which runs at a much lower frequency.

@freezy freezy self-assigned this Mar 12, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2021

Codecov Report

Merging #293 (9e4cc67) into master (18dc40e) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 9e4cc67 differs from pull request most recent head 9932f34. Consider uploading reports for the commit 9932f34 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
- Coverage   66.03%   66.00%   -0.03%     
==========================================
  Files         136      136              
  Lines        8420     8423       +3     
  Branches      866      868       +2     
==========================================
  Hits         5560     5560              
- Misses       2623     2625       +2     
- Partials      237      238       +1     
Impacted Files Coverage Δ
...Pinball.Engine/Game/Engines/GamelogicEngineCoil.cs 40.00% <ø> (ø)
...Pinball.Engine/Game/Engines/GamelogicEngineLamp.cs 50.00% <ø> (ø)
...nball.Engine/Game/Engines/GamelogicEngineSwitch.cs 100.00% <ø> (ø)
VisualPinball.Engine/VPT/Mappings/Mappings.cs 81.75% <0.00%> (-0.58%) ⬇️
...ualPinball.Engine/VPT/Mappings/MappingsWireData.cs 42.85% <0.00%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58c2421...9932f34. Read the comment docs.

@freezy
Copy link
Copy Markdown
Owner Author

freezy commented Mar 16, 2021

It's the MPF doc, feel free to push directly to this branch.

@freezy freezy changed the title Add support for dynamic wires MPF / Add support for dynamic wires Mar 16, 2021
@freezy freezy merged commit f0b7509 into master Mar 17, 2021
@freezy freezy deleted the feature/mpf branch March 17, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants