Runtime camera controller update and new clipping component. #304
Merged
Conversation
Added a camera clipping plane adjustment component.
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
=======================================
Coverage 66.00% 66.00%
=======================================
Files 136 136
Lines 8423 8423
Branches 868 868
=======================================
Hits 5560 5560
Misses 2625 2625
Partials 238 238 Continue to review full report at Codecov.
|
freezy
reviewed
Jun 11, 2021
Owner
freezy
left a comment
freezy
left a comment
There was a problem hiding this comment.
Thanks, this is great. I've added a few comments, but I couldn't test it yet, so I'll have a look at CameraController later tonight. Cheers!
Co-authored-by: freezy <freezy@kodi.tv>
Co-authored-by: freezy <freezy@kodi.tv>
Adjusted the style and removed unused returns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added runtime camera controls to the camera controller. Removed old camera clip plane adjustment setup. Added new stand-alone camera clip plane component to allow alternate camera controllers.