Remove Hybrid Renderer#316
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
==========================================
+ Coverage 83.62% 85.39% +1.76%
==========================================
Files 136 136
Lines 7444 7442 -2
==========================================
+ Hits 6225 6355 +130
+ Misses 1219 1087 -132
Continue to review full report at Codecov.
|
This was referenced Jul 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few issues with Hybrid Renderer, apart from stability there are missing features like mesh skinning and DXR. As far as I understood, the advantage of the Hybrid Render is more efficient data handling in case of rendering hundreds of thousands of objects. So VPE should be fine with the GameObject approach.
vpe-no-hybrid.mp4
This PR removes the Hybrid Renderer dependency, keeps the GameObjects during DOTS conversion, and updates the DOTS systems to update GameObjects instead of the DOTS rendering components.
One of the bigger simplifications was the plunger animation, for which @Pandelii created a shader graph for lerp-animating vertices. Now we just use the skinned mesh renderer and set the blend shape weight.
I've posted about this at the Unity forums as well, and apparently it's a common approach. One thing we might consider in the future is to use DOTS Hybrid Components instead of
Mode.ConvertAndInjectGameObject.