Generate meshes for playfield inserts#320
Merged
Merged
Conversation
This was referenced Sep 14, 2021
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
==========================================
- Coverage 82.86% 82.79% -0.08%
==========================================
Files 126 126
Lines 6841 6846 +5
==========================================
- Hits 5669 5668 -1
- Misses 1172 1178 +6
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generates meshes for the playfield inserts. Since inserts are not a VPX feature per SE, we assume a light is an insert if:
The mesh is only generated if both of these apply.
You can set the Z-position as well as the height of the created mesh in the inspector. The following shot shows the generated meshes for T2:
TODO:
In order to support drag point editing (since we're on a non-main component containing the drag points), there was some refactoring necessary.
DragPointItemInspector<>is gone now and replaced by aDragPointInspectorHelperthat is instantiated instead. Bonus: Everything is typed correctly and all editor-related logic is in the inspector and not the component.This PR closes #281.