Light Management and Lag Compensation#330
Merged
Merged
Conversation
This reverts commit dffc8b8.
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 83.14% 83.43% +0.28%
==========================================
Files 124 125 +1
Lines 6718 6736 +18
==========================================
+ Hits 5586 5620 +34
+ Misses 1132 1116 -16
Continue to review full report at Codecov.
|
This was referenced Oct 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR revamps the lamp manager to support GI lights and light groups. It also introduces lag compensation through what we call dynamic wires.
Lamps
Most of the work on lamps is related to GI. We now pull them from PinMAME, and you can set them up correctly in the lamp manager. Still untested are RGB lamps.
t2-gi.mp4
Dynamic Wires
It's best to read the documentation here.
t2-lag2.mp4
The video show the latency from PinMAME that is now by-passed by the dynamic wire.
Patching
I've started porting T2 to VPE. While all changes can be made in the editor, I currently prefer doing them in a patcher script, so I can easily adapt and don't need to deal with a Unity scene for the changelog. For that a few more APIs were added to patcher and the abstraction layers for materials and lights. Also, the T2 patcher is kind of big now. ;)