Add free transformation for lights.#350
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
=======================================
Coverage 83.91% 83.91%
=======================================
Files 125 125
Lines 6741 6741
=======================================
Hits 5657 5657
Misses 1084 1084 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, every GameObject had a transformation override, i.e. our custom code handled how the object could be transformed. This was to be sure that the object wasn't moved outside of what the physics engine supports.
However, there are GameObjects like lights that don't concern the physics engine and handling the transformation on our own only complicates things. More concretely, the problem we solved was being able to simply add a
LightComponentto existing lights without the override getting confused.In the future we could apply this to objects that can be freely transformed like primitives as well.
Additionally, code was added to fade emissive materials along with the light, should they be a child of one. It's still hacky because we multiply the alpha value with
0.3fto get somewhat correct results.Video of it in action:
https://www.youtube.com/watch?v=wLd4VGZUKmU
Lastly, I've updated the documentation and screenshots of the setup process to work with Unity 2021.2.