Skip to content

Add scale parameter to trigger.#374

Merged
freezy merged 5 commits into
masterfrom
feature/scaling-triggers
Jan 24, 2022
Merged

Add scale parameter to trigger.#374
freezy merged 5 commits into
masterfrom
feature/scaling-triggers

Conversation

@freezy
Copy link
Copy Markdown
Owner

@freezy freezy commented Jan 23, 2022

This just adds a scale parameter to the trigger, so we can more easily scale the mesh.

It also fixes the bounding box of the plunger, fixing it disappearing all the time, and bumps the copyright notice of all files to 2022.

@freezy freezy self-assigned this Jan 23, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 23, 2022

Codecov Report

Merging #374 (2ff7b0c) into master (e2dfa0b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #374   +/-   ##
=======================================
  Coverage   84.13%   84.13%           
=======================================
  Files         128      128           
  Lines        6973     6973           
=======================================
  Hits         5867     5867           
  Misses       1106     1106           
Impacted Files Coverage Δ
VisualPinball.Engine/Common/EngineProvider.cs 90.00% <ø> (ø)
VisualPinball.Engine/Common/Logging.cs 0.00% <ø> (ø)
VisualPinball.Engine/Common/Profiler.cs 0.00% <ø> (ø)
VisualPinball.Engine/Common/Registry.cs 0.00% <ø> (ø)
VisualPinball.Engine/Common/StringExtensions.cs 100.00% <ø> (ø)
...Pinball.Engine/Game/Engines/GamelogicEngineCoil.cs 68.75% <ø> (ø)
...Pinball.Engine/Game/Engines/GamelogicEngineLamp.cs 73.68% <ø> (ø)
...nball.Engine/Game/Engines/GamelogicEngineSwitch.cs 100.00% <ø> (ø)
...Pinball.Engine/Game/Engines/GamelogicEngineWire.cs 100.00% <ø> (ø)
VisualPinball.Engine/IO/BiffAttribute.cs 96.26% <ø> (ø)
... and 116 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2dfa0b...2ff7b0c. Read the comment docs.

@freezy freezy force-pushed the feature/scaling-triggers branch from bc4c72f to 615ac51 Compare January 24, 2022 21:30
@freezy freezy merged commit 4950233 into master Jan 24, 2022
@freezy freezy deleted the feature/scaling-triggers branch January 24, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant