Skip to content

Export meshes to FBX and other small changes.#387

Merged
freezy merged 17 commits into
masterfrom
feature/quality-of-life
Apr 8, 2022
Merged

Export meshes to FBX and other small changes.#387
freezy merged 17 commits into
masterfrom
feature/quality-of-life

Conversation

@freezy
Copy link
Copy Markdown
Owner

@freezy freezy commented Mar 13, 2022

Thanks to @jsm174 for figuring out how to make the damn FBX package work on Linux. I had to cheat a bit for the unit tests too, because somehow the geometry was slightly changed.

The other small change was fixing the locked hierarchy window in one of the provided layouts.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2022

Codecov Report

Merging #387 (9782235) into master (5d14442) will decrease coverage by 0.16%.
The diff coverage is 75.00%.

❗ Current head 9782235 differs from pull request most recent head 11a0140. Consider uploading reports for the commit 11a0140 to get more accurate results

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
- Coverage   83.51%   83.34%   -0.17%     
==========================================
  Files         128      128              
  Lines        7043     7081      +38     
==========================================
+ Hits         5882     5902      +20     
- Misses       1161     1179      +18     
Impacted Files Coverage Δ
VisualPinball.Engine/Math/Vertex3DNoTex2.cs 75.32% <40.00%> (-2.46%) ⬇️
VisualPinball.Engine/VPT/Mesh.cs 72.60% <80.00%> (-2.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31625eb...11a0140. Read the comment docs.

@jsm174
Copy link
Copy Markdown
Collaborator

jsm174 commented Mar 13, 2022

Thanks to @jsm174 for figuring out how to make the damn FBX package work on Linux. I had to cheat a bit for the unit tests too, because somehow the geometry was slightly changed.

Cool. Just for some notes incase we ever have to revisit this:

game-ci's test runner is currently built on Ubuntu 18.04. Out of the box, Ubuntu 18.04 has libstdc++.so.6.0.25 installed.

According to: https://docs.unity3d.com/Packages/com.autodesk.fbx@4.1/manual/index.html, libstdc++.so.6.0.28+ is required.

So as a work around, we need to temporarily use a custom game-ci unity test runner image base on Ubuntu 18 that has an upgraded libstdc++. When game-ci upgrades to Ubuntu 20, we can go back to official images.

To upgrade libstdc++, we made a custom Dockerfile:

FROM unityci/editor:2021.2.15f1-linux-il2cpp-0
RUN apt-get update && apt-get -y install software-properties-common && add-apt-repository -y ppa:ubuntu-toolchain-r/test && apt-get -y install --only-upgrade libstdc++6
docker build . -t jsm174/unityci_editor:2021.2.15f1-linux-il2cpp-0`
docker push jsm174/unityci_editor:2021.2.15f1-linux-il2cpp-0

This article was also helping in tracking this down:

https://forum.unity.com/threads/fbx-exporter-4-0-1-does-not-work-with-unity-2021-1-11-on-linux.1131481/

@freezy
Copy link
Copy Markdown
Owner Author

freezy commented Mar 22, 2022

@jsm174 this is ready to merge now, right?

@jsm174
Copy link
Copy Markdown
Collaborator

jsm174 commented Mar 22, 2022

@jsm174 this is ready to merge now, right?

yes. In a future PR we will be able to remove the line: customImage: 'unityci/editor:2021.2.16f1-linux-il2cpp-1'.

I believe game-ci/unity-test-runner needs to make a new release so it pulls its latest image.

@freezy
Copy link
Copy Markdown
Owner Author

freezy commented Mar 22, 2022

Cool, can you watch this and update accordingly?

@freezy freezy force-pushed the feature/quality-of-life branch from 741a52d to 7a55601 Compare March 22, 2022 23:12
@jsm174 jsm174 force-pushed the feature/quality-of-life branch from 06e47cf to 21e493a Compare March 30, 2022 11:15
@jsm174
Copy link
Copy Markdown
Collaborator

jsm174 commented Apr 3, 2022

@freezy - unity-test-runner@main was just updated to pull v1 images. (game-ci/unity-test-runner#179)

This is good to merge now.

@jsm174 jsm174 force-pushed the feature/quality-of-life branch from 9782235 to 11a0140 Compare April 4, 2022 18:04
@freezy
Copy link
Copy Markdown
Owner Author

freezy commented Apr 4, 2022

Awesome, thanks!

But I wanted to fix colored material emission before merging. If I don't get to until tomorrow I'll merge nevertheless though.

@freezy freezy merged commit c3c617e into master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants