Export meshes to FBX and other small changes.#387
Conversation
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
==========================================
- Coverage 83.51% 83.34% -0.17%
==========================================
Files 128 128
Lines 7043 7081 +38
==========================================
+ Hits 5882 5902 +20
- Misses 1161 1179 +18
Continue to review full report at Codecov.
|
Cool. Just for some notes incase we ever have to revisit this: game-ci's test runner is currently built on Ubuntu 18.04. Out of the box, Ubuntu 18.04 has According to: https://docs.unity3d.com/Packages/com.autodesk.fbx@4.1/manual/index.html, So as a work around, we need to temporarily use a custom game-ci unity test runner image base on Ubuntu 18 that has an upgraded libstdc++. When game-ci upgrades to Ubuntu 20, we can go back to official images. To upgrade libstdc++, we made a custom Dockerfile: This article was also helping in tracking this down: |
8484ff0 to
bcabc68
Compare
|
@jsm174 this is ready to merge now, right? |
yes. In a future PR we will be able to remove the line: I believe |
|
Cool, can you watch this and update accordingly? |
741a52d to
7a55601
Compare
06e47cf to
21e493a
Compare
|
@freezy - This is good to merge now. |
…rnal ID when setting a coil as lamp.
9782235 to
11a0140
Compare
|
Awesome, thanks! But I wanted to fix colored material emission before merging. If I don't get to until tomorrow I'll merge nevertheless though. |
Thanks to @jsm174 for figuring out how to make the damn FBX package work on Linux. I had to cheat a bit for the unit tests too, because somehow the geometry was slightly changed.
The other small change was fixing the locked hierarchy window in one of the provided layouts.