Feature/live catch#436
Merged
Merged
Conversation
Collaborator
Author
|
Argh. Forgot to check if the checkbox is checked... Will add that tomorrow. |
Owner
|
Amazing! This is on my to-review list today :) |
Collaborator
Author
You can test it quite well, if you set the perfect time to 0.5 secs and full time to 1s. It is "just a tad" easier then :-) |
freezy
approved these changes
Sep 5, 2022
Owner
freezy
left a comment
There was a problem hiding this comment.
Fantastic stuff! I've pushed a few minor changes, such as variable naming, added units to the inspector, and made one method static.
Collaborator
Author
|
"Bump on release" has to be greyed out or commented out, since not yet implemented (comes with flipper-bounce in some weeks). Will add a commit for this next day(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds live catch to flippers.
There are some differences to nFozzy:
The default vales differ from nFozzy's script, because of 1 and 5.