You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the contribution, @njlr! Great to see another PR from you. 🎉
A few observations on the implementation:
Implementation quality ✅
The chooseV implementation is clean and correct. It mirrors the existing choose implementation exactly — using the for item in source do pattern — which is ideal.
Naming ✅ chooseV / chooseVAsync is a reasonable naming choice for the ValueOption variant. The V suffix is a common convention in the F# ecosystem (e.g., Array.tryFindIndexV in some libraries, ValueSome/ValueNone in FSharp.Core). Within this library there's no prior V-suffix API yet, but given the direct parallel to choose/chooseAsync, the naming is clear and discoverable.
Consistency note — the PR touches four files appropriately: TaskSeqInternal.fs (implementation), TaskSeq.fs (public type), TaskSeq.fsi (signature), and the test project. The tests cover empty sequences, immutable variants, side effects, and type-changing — well done.
One small suggestion: would it be worth adding a release-notes.txt entry? Per the project conventions (see AGENTS.md), every user-visible change should have a bullet under the current version heading (1.0.0). Something like:
- adds TaskSeq.chooseV and TaskSeq.chooseVAsync for ValueOption-returning choosers
Otherwise this looks good to me! The follow-up for tryPickV/pickV sounds like a natural next step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValueOptionvariants forchoose:TaskSeq.chooseV,TaskSeq.chooseVAsyncchooseTaskSeq.tryPick,TaskSeq.picketc. if desired