FSharp.Data.GraphQL.Client: ID deserialization fails

[draganjovanovic1]

Description

My mutations return ID graph type. Response deserialization fails when I execute mutation. Seems like code on L356 (ID not handled) is not aligned with L344 (ID hadled).

https://github.com/fsprojects/FSharp.Data.GraphQL/blob/dev/src/FSharp.Data.GraphQL.Client/BaseTypes.fs#L344
https://github.com/fsprojects/FSharp.Data.GraphQL/blob/dev/src/FSharp.Data.GraphQL.Client/BaseTypes.fs#L356

Schema for one mutation:

              {
                "name": "registerCustomer",
                "description": "Registers new customer",
                "args": [
                  {
                    "name": "id",
                    "description": "Customer immutable id",
                    "type": {
                      "kind": "NON_NULL",
                      "name": null,
                      "ofType": {
                        "kind": "SCALAR",
                        "name": "ID",
                        "ofType": null
                      }
                    },
                    "defaultValue": "null"
                  },
                  {
                    "name": "commandId",
                    "description": "Command id (optional)",
                    "type": {
                      "kind": "SCALAR",
                      "name": "ID",
                      "ofType": null
                    },
                    "defaultValue": "null"
                  },
                  {
                    "name": "firstName",
                    "description": "Customer first name",
                    "type": {
                      "kind": "NON_NULL",
                      "name": null,
                      "ofType": {
                        "kind": "SCALAR",
                        "name": "String",
                        "ofType": null
                      }
                    },
                    "defaultValue": "null"
                  },
                  {
                    "name": "lastName",
                    "description": "Customer last name",
                    "type": {
                      "kind": "NON_NULL",
                      "name": null,
                      "ofType": {
                        "kind": "SCALAR",
                        "name": "String",
                        "ofType": null
                      }
                    },
                    "defaultValue": "null"
                  },
                  {
                    "name": "email",
                    "description": "Email address",
                    "type": {
                      "kind": "INPUT_OBJECT",
                      "name": "RegisterEmailInput",
                      "ofType": null
                    },
                    "defaultValue": "null"
                  },
                  {
                    "name": "cellPhone",
                    "description": "Cell phone",
                    "type": {
                      "kind": "INPUT_OBJECT",
                      "name": "RegisterCellPhoneInput",
                      "ofType": null
                    },
                    "defaultValue": "null"
                  }
                ],
                "type": {
                  "kind": "SCALAR",
                  "name": "ID",
                  "ofType": null
                },
                "isDeprecated": false,
                "deprecationReason": null
              }

Repro steps

Make mutation which returns ID only. Execute it.

Expected behavior

Response should be deserialized.

Actual behavior

Response deserialization fails.

Known workarounds

Use String instead of ID.

Related information

.NET Core SDK 2.2.401

[johnberzy-bazinga]

Custom scalars that are not known by the provider should be (de)serialized as strings. I'll take a look at why it's not working that way.

Thanks for the report!
John

[blakeSaucier]

I'm also having this issue - thanks.

[johnberzy-bazinga]

@draganjovanovic1 @blakeSaucier. This should be fixed now. Custom scalars will be treated as strings by the provider.