Skip to content

Migrate integration tests to in-process hosts via WebApplicationFactory and remove external server orchestration from build#564

Merged
xperiandri merged 23 commits into
devfrom
copilot/use-webapplicationfactory-integration-tests
May 17, 2026
Merged

Migrate integration tests to in-process hosts via WebApplicationFactory and remove external server orchestration from build#564
xperiandri merged 23 commits into
devfrom
copilot/use-webapplicationfactory-integration-tests

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 17, 2026 •
edited
Loading

  • Review the new PR comments and identify the requested reverts
  • Inspect current branch state and recent build/workflow status
  • Revert the sample-local introspection.json addition and related project wiring
  • Point the StarWars sample back to the introspection file maintained by tests
  • Run targeted build validation for the affected .slnx/sample files
  • Reply to the new review comments with the addressing commit hash

Copilot AI linked an issue May 17, 2026 that may be closed by this pull request
Use WebApplicationFactory to run integration test hosts #563
Closed
Copilot AI changed the title [WIP] Use WebApplicationFactory to run integration tests Migrate integration tests to in-process hosts via WebApplicationFactory and remove external server orchestration from build May 17, 2026
Copilot AI requested a review from xperiandri May 17, 2026 01:02
@xperiandri xperiandri changed the title Migrate integration tests to in-process hosts via WebApplicationFactory and remove external server orchestration from build Migrate integration tests to in-process hosts via WebApplicationFactory and remove external server orchestration from build May 17, 2026
@xperiandri xperiandri force-pushed the copilot/use-webapplicationfactory-integration-tests branch from 0a5c2fe to 26c0f41 Compare May 17, 2026 13:11
xperiandri
xperiandri reviewed May 17, 2026
View reviewed changes
Comment thread tests/FSharp.Data.GraphQL.IntegrationTests/SwapiRemoteProviderTests.fs Outdated
xperiandri
xperiandri reviewed May 17, 2026
View reviewed changes
Comment thread tests/FSharp.Data.GraphQL.IntegrationTests/FSharp.Data.GraphQL.IntegrationTests.fsproj Outdated
Copilot AI requested a review from xperiandri May 17, 2026 13:23
xperiandri
xperiandri reviewed May 17, 2026
View reviewed changes
Comment thread build/Program.fs
Copilot AI requested a review from xperiandri May 17, 2026 13:46
xperiandri
xperiandri reviewed May 17, 2026
View reviewed changes
Comment thread build/Program.fs
==> StartStarWarsServerTarget
==> BuildIntegrationTestServerTarget
==> StartIntegrationServerTarget
==> UpdateIntrospectionFileTarget
Copy link
Copy Markdown
Collaborator

@xperiandri xperiandri May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot мне кажется что обновлять introspection всё таки нужно

Copy link
Copy Markdown
Contributor Author

Copilot AI May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вернул обновление introspection в дефолтную цепочку: добавил StartStarWarsServerTarget и UpdateIntrospectionFileTarget перед All в build/Program.fs. Коммит: 038c282.

Copilot AI and others added 11 commits May 17, 2026 17:15
@xperiandri
Rename introspection stream variable for clarity
a953ff4 
Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/4998e0af-9a24-4088-a9a9-3318b08f3de9

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
@xperiandri
Replace lazy shared test clients with explicit client factory methods
4c3e468 
Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/e9009367-0c5a-44a7-986e-7b0cfa2a3f94

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
@xperiandri
Refactor repeated friends index access in remote provider tests
4b3788c 
Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/79103f2d-049f-4772-91c8-b1fc8f9d2000

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
@xperiandri
Apply do blocks for friend assertions in SwapiRemoteProviderTests
6e3b98a 
Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/627b62ae-6908-4700-b7a5-0f086062cb58

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
@xperiandri
Remove unused integration test targets from build script
cf98a5a 
Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/9c34412f-ef8d-4b05-8181-ef289781e3be

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
@xperiandri
Restore introspection update in default build target chain
28a3e9a 
Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/8c78aed3-f9e5-4eef-a936-0f3de0a59126

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
@xperiandri
Restore introspection refresh in BuildAndTest target pipeline
b9516f2 
Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/17ad608b-6898-4180-9667-6ac02942a225

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
@xperiandri
Plan: replace custom introspection update target with test invocation
c2bd3b5 
Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/9a7df672-dce9-4c9f-aafd-46ac6e2058c6

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
@xperiandri
Replace custom introspection update logic with integration test execu…
7b3e9b8 
…tion

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/9a7df672-dce9-4c9f-aafd-46ac6e2058c6

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
@xperiandri
Use integration introspection update tests in build pipeline
da16a5e 
Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/9a7df672-dce9-4c9f-aafd-46ac6e2058c6

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
@xperiandri
Revert unintended introspection.json change
5867d45 
Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/9a7df672-dce9-4c9f-aafd-46ac6e2058c6

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
@xperiandri xperiandri force-pushed the copilot/use-webapplicationfactory-integration-tests branch from ab0166f to 5867d45 Compare May 17, 2026 15:15
Copilot AI and others added 2 commits May 17, 2026 15:28
@xperiandri
Fix slnx build blockers
9d1b0e0 
Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/89e5acaf-53c4-4e34-b7ed-ce34b90af854

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
@xperiandri
Stabilize sample introspection build inputs
db23e2c 
Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/89e5acaf-53c4-4e34-b7ed-ce34b90af854

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
Copilot AI requested a review from xperiandri May 17, 2026 15:33
xperiandri
xperiandri requested changes May 17, 2026
View reviewed changes
Comment thread samples/star-wars-fabulous-client/StarWars/introspection.json Outdated
Copy link
Copy Markdown
Collaborator

@xperiandri xperiandri May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot revert

Copy link
Copy Markdown
Contributor Author

Copilot AI May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted in 5179f08.

Comment thread samples/star-wars-fabulous-client/StarWars/Common.fs Outdated

type GraphQLApi = GraphQLProvider<"http://localhost:8086">
[<Literal>]
let IntrospectionPath = "introspection.json"
Copy link
Copy Markdown
Collaborator

@xperiandri xperiandri May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot это херня! Как этот файл обновляться будет???
Сошлись на этот файл в тестах

Copy link
Copy Markdown
Contributor Author

Copilot AI May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправил: sample снова ссылается на ../../../tests/FSharp.Data.GraphQL.IntegrationTests/introspection.json, локальный snapshot убран. Коммит: 5179f08.

Comment thread tests/FSharp.Data.GraphQL.IntegrationTests/FSharp.Data.GraphQL.IntegrationTests.fsproj Outdated
Copilot AI requested a review from xperiandri May 17, 2026 16:25
@xperiandri xperiandri marked this pull request as ready for review May 17, 2026 17:25
@xperiandri xperiandri merged commit 5f5eff4 into dev May 17, 2026
3 checks passed
@xperiandri xperiandri deleted the copilot/use-webapplicationfactory-integration-tests branch May 17, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Juriyx Juriyx Juriyx approved these changes

+1 more reviewer

@xperiandri xperiandri xperiandri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@xperiandri xperiandri

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use WebApplicationFactory to run integration test hosts

3 participants

@xperiandri @Juriyx