Skip to content

[Repo Assist] Fix JsonProvider pluralizer incorrectly singularizing '-ases' words (e.g. 'purchases' → 'purchasis') #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 2 commits into from
Closed

[Repo Assist] Fix JsonProvider pluralizer incorrectly singularizing '-ases' words (e.g. 'purchases' → 'purchasis') #1600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1922a2c
Fix pluralizer incorrectly singularizing words ending in '-ases' (e.g…
Feb 21, 2026
0eda712
Merge branch 'main' into fix/pluralizer-ase-suffix-1508-c17a963eb8e454d4
dsyme Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/FSharp.Data.Runtime.Utilities/Pluralizer.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ let private tables =

"cis", "ces"
"us", "uses"
"ase", "ases"
"sis", "ses"
"xis", "xes"

Expand Down Expand Up @@ -148,6 +149,7 @@ let private tables =
"murex", "murecis", ""
"mythos", "mythos", "mythoi"
"news", "", ""
"oasis", "oases", ""
"octopus", "octopuses", "octopodes"
"ovum", "ova", ""
"ox", "ox", "oxen"
Expand Down
15 changes: 15 additions & 0 deletions tests/FSharp.Data.Core.Tests/Pluralizer.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,21 @@ let ``Roundtrip consistency for common words`` () =
word <> "aircraft" && word <> "series" then
backToSingular |> should equal word

[<Test>]
let ``Purchases singularizes correctly - regression test for issue 1508`` () =
// Previously "purchases" was incorrectly singularized to "purchasis"
// due to the "sis"/"ses" suffix rule matching words ending in "ses"
toSingular "purchases" |> should equal "purchase"
toPlural "purchase" |> should equal "purchases"
// Other "-ase" words should also work correctly
toSingular "cases" |> should equal "case"
toSingular "phases" |> should equal "phase"
toSingular "phrases" |> should equal "phrase"
toSingular "vases" |> should equal "vase"
// "oases" should still correctly singularize to "oasis" (via special word list)
toSingular "oases" |> should equal "oasis"
toPlural "oasis" |> should equal "oases"

[<Test>]
let ``Performance with repeated calls`` () =
// Test that repeated calls with same input work correctly (testing lazy initialization)
Expand Down
Loading