Skip to content

[repo-assist] perf: XmlDoc.escapeXml fast-path + UniqueNameGenerator ToLowerInvariant dedup #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergey-tihon merged 3 commits into from
May 10, 2026
Merged

[repo-assist] perf: XmlDoc.escapeXml fast-path + UniqueNameGenerator ToLowerInvariant dedup #429

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f97b358
perf: add IndexOfAny fast-path to escapeXml; precompute lowercase key…
github-actions[bot] May 10, 2026
210eed0
ci: trigger checks
github-actions[bot] May 10, 2026
7c5a456
Potential fix for pull request finding
sergey-tihon May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions src/SwaggerProvider.DesignTime/Utils.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,16 @@ module XmlDoc =
open System.Text.Json
open System.Text.Json.Nodes

// Fast-path: skip all allocations when the string has no XML special characters.
// In practice the vast majority of OpenAPI descriptions are plain English text,
// so this check pays for itself immediately.
let private xmlSpecialChars = [| '&'; '<'; '>' |]

let private escapeXml(s: string) =
s.Replace("&", "&amp;").Replace("<", "&lt;").Replace(">", "&gt;")
if s.IndexOfAny(xmlSpecialChars) < 0 then
s
else
s.Replace("&", "&amp;").Replace("<", "&lt;").Replace(">", "&gt;")

let private formatEnumValue(v: JsonNode) =
if isNull v then
Expand Down Expand Up @@ -385,15 +393,19 @@ type UniqueNameGenerator(?occupiedNames: string seq) =
for name in (defaultArg occupiedNames Seq.empty) do
hash.Add(name.ToLowerInvariant()) |> ignore

let rec findUniq prefix i =
let newName = sprintf "%s%s" prefix (if i = 0 then "" else i.ToString())
let key = newName.ToLowerInvariant()
// Compute the lowercase prefix once per MakeUnique call; on each collision
// only the numeric suffix needs to be appended, avoiding repeated ToLowerInvariant
// calls on the full name string.
let rec findUniq prefix prefixLower i =
let newName = if i = 0 then prefix else $"{prefix}{i}"
let key = if i = 0 then prefixLower else $"{prefixLower}{i}"

match hash.Contains key with
| false ->
hash.Add key |> ignore
newName
| true -> findUniq prefix (i + 1)
| true -> findUniq prefix prefixLower (i + 1)

member _.MakeUnique methodName =
Comment thread
sergey-tihon marked this conversation as resolved.
findUniq methodName 0
let methodName = if isNull methodName then "" else methodName
findUniq methodName (methodName.ToLowerInvariant()) 0
Loading