[repo-assist] refactor: replace last sprintf with string interpolation in DefinitionCompiler

[github-actions]

🤖 This PR was created by Repo Assist, an automated AI assistant.

Summary

Replaces the sole remaining sprintf call in production code with the conditional string-interpolation pattern already established in Utils.fs:

Before

let newName = sprintf "%s%s" prefix (if i = 0 then "" else i.ToString())

After

let newName = if i = 0 then prefix else $"{prefix}{i}"

This is the same pattern already used in UniqueNameGenerator.findUniq (Utils.fs):

let newName = if i = 0 then prefix else $"{prefix}{i}"
let key = if i = 0 then prefixLower else $"{prefixLower}{i}"

Rationale

• Removes the intermediate i.ToString() allocation before the sprintf format call
• Makes DefinitionCompiler consistent with Utils.fs
• Removes the last sprintf from production source code (only one remained)
• No behavior change — semantics are identical

Test Status

✅ Build succeeded (0 errors, 210 warnings — pre-existing)
✅ All 417 unit tests passed

Generated by 🌈 Repo Assist, see workflow run. Learn more.

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@79c99dfd73f3b7ad8ab2b0f4944838018dbe4736

[Copilot]

Pull request overview

Trivial refactor replacing the final sprintf in DefinitionCompiler.fs with a string-interpolation pattern already established in Utils.fs's UniqueNameGenerator.findUniq.

Changes:

• Replace sprintf "%s%s" prefix (if i = 0 then "" else i.ToString()) with if i = 0 then prefix else $"{prefix}{i}"

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.