Skip to content

Don't import pyarrow just to check version#503

Merged
martindurant merged 4 commits into
fsspec:masterfrom
martindurant:dont_import_pyarrow
Dec 18, 2020
Merged

Don't import pyarrow just to check version#503
martindurant merged 4 commits into
fsspec:masterfrom
martindurant:dont_import_pyarrow

Conversation

@martindurant

Copy link
Copy Markdown
Member

We would rather not import pyarrow, since from v2.0.0, we don't use it anyway.

Ref #411

cc @jorisvandenbossche - this is the chain of version checks that we talked about in your PR.

[ ] %time import fsspec
93 ms (this branch)
183 ms (master)

@jorisvandenbossche

Copy link
Copy Markdown
Contributor

Looks good!

@martindurant martindurant merged commit a5bb951 into fsspec:master Dec 18, 2020
@martindurant martindurant deleted the dont_import_pyarrow branch December 18, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants