Skip to content

Inherit from pathlib_abc.PathBase#270

Closed
ap-- wants to merge 29 commits into
fsspec:mainfrom
ap--:pathlib-pathbase
Closed

Inherit from pathlib_abc.PathBase#270
ap-- wants to merge 29 commits into
fsspec:mainfrom
ap--:pathlib-pathbase

Conversation

@ap--

@ap-- ap-- commented Sep 3, 2024

Copy link
Copy Markdown
Collaborator

To improve maintainability when new Python versions are released and to integrate better with upstream as well as downstream libraries, we're moving to pathlib_abc.PathBase as our base class for UPath.

This draft PR makes UPath inherit from PathBase, introduces PureUPath, and a "parser" (formerly 'flavour') based on ParserBase.

There's still quite a bit of work to be done to make all tests pass, but I'm pushing this here for people to follow along.

This PR will close #114, close #193, close #221 and close #245

@ap-- ap-- self-assigned this Sep 3, 2024
@ap--

ap-- commented Sep 3, 2024

Copy link
Copy Markdown
Collaborator Author

A lot of the path parsing in PurePathBase depends on the correct behavior of ParserBase.split. I should write tests for all supported filesystems how split should behave.

@ap--

ap-- commented May 8, 2025

Copy link
Copy Markdown
Collaborator Author

This PR was replaced by #366

@ap-- ap-- closed this May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test regressions with Python 3.13 Test against 3.13 Inherit from PathBase instead of Path Heads up: pathlib._PathBase may be coming soon

1 participant