Skip to content

chore: update fullsend shim workflow#41

Merged
waynesun09 merged 1 commit into
mainfrom
fullsend/onboard
Jul 17, 2026
Merged

chore: update fullsend shim workflow#41
waynesun09 merged 1 commit into
mainfrom
fullsend/onboard

Conversation

@fullsend-ai-fullsend

Copy link
Copy Markdown
Contributor

This PR updates the fullsend shim workflow to match the current template in the .fullsend config repo.

The shim content has drifted from the template — this brings it back in sync.

@fullsend-ai-fullsend
fullsend-ai-fullsend Bot requested a review from a team as a code owner July 16, 2026 14:57
Update the shim workflow to match the current template
in the .fullsend config repo.
@waynesun09
waynesun09 added this pull request to the merge queue Jul 17, 2026
Merged via the queue into main with commit 5d8bed2 Jul 17, 2026
4 checks passed
@waynesun09
waynesun09 deleted the fullsend/onboard branch July 17, 2026 12:19
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jul 17, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 12:21 PM UTC · Completed 12:30 PM UTC
Commit: 521ed8b · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #41chore: update fullsend shim workflow

What happened: PR #41 was a trivial, fully automated PR created by fullsend-ai-fullsend[bot] to sync the .github/workflows/fullsend.yaml shim with the canonical template. The sole change added labeled and unlabeled to the pull_request_target event types (1 line changed). The PR was merged by waynesun09 approximately 21 hours after creation with zero reviews — neither human nor automated.

Key observations:

  1. Review agent never dispatched. The dispatch workflow's has_write_permission() function queries the GitHub collaborator permission API, which returns an empty role for GitHub App bot accounts (they authenticate via installation tokens, not collaborator roles). This caused all three pre-merge dispatch attempts to output "No stage matched — skipping dispatch." This is a known gap tracked in fullsend#5188.

  2. Retro agent dispatched on a zero-agent-involvement bot PR. The retro stage triggered unconditionally on the closed event, spending compute analyzing a PR with no agent interaction to evaluate. This pattern is tracked in fullsend#5185 and fullsend#3226.

  3. No review of any kind before merge. The combination of the dispatch gap (#5188) and the absence of branch protection requiring reviews meant this workflow file change landed with no automated or human quality gate. The experiments repo already tracks a related improvement in experiments#37 (enforce required human review for protected paths).

No new proposals filed. All improvement opportunities identified in this retro are already covered by existing open issues. The most impactful fixes would be resolving fullsend#5188 (enable review dispatch for org-owned bot PRs) and fullsend#5185 (skip or minimize retro for zero-agent-involvement bot PRs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant