feat(install): MCP preselection parity, YOLO prompt, v2 engine flag - #15
Merged
Conversation
initialValues now follow the Claude installer's getDefaultSelections: explicit default wins, otherwise no-key servers plus key-required ones whose apiKeyEnv is already set. Key-required entries are labelled [check] / [key missing] in the multiselect, like buildMcpOptions.
configurePermissionMode: TTY select (YOLO ON/OFF, seeded with the current value) persists default_permission_mode in config.toml via a surgical line edit; non-TTY honors FUSENGINE_PERMISSION_MODE, else no-op. configureExperimentalFlag: custom agents are only discovered by the v2 engine (v1 backport #2232 not yet released), so the installer proposes KIMI_CODE_EXPERIMENTAL_FLAG=1 in the detected shell rc (default YES, guarded idempotent block). Kimi does not read $KIMI_HOME/.env, so the export must live in the shell rc. Non-TTY applies only with the explicit FUSENGINE_EXPERIMENTAL_FLAG=1 opt-in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three installer improvements, discovered while comparing with the Claude Code installer:
MCP preselection parity (
mcp-select.ts):initialValuesuseddefault !== false, pre-selecting key-required servers even when the key is missing. Now follows the Claude rule (getDefaultSelections): explicitdefaultwins, otherwise no-key servers plus key-required ones whoseapiKeyEnvis already set. Key-required entries show[✓]/[⚠ key missing]labels, likebuildMcpOptions.YOLO permission mode step (
permission-mode.ts): TTY select (OFF manual / ON yolo, seeded with the current value) persistsdefault_permission_modein$KIMI_HOME/config.tomlvia a surgical line edit (everything else preserved). Non-TTY:FUSENGINE_PERMISSION_MODE=manual|yolo|auto, else no-op.v2 engine flag step (
experimental-flag.ts): custom agents (~/.kimi-code/agents/*.md) are only discovered by the v2 engine — the v1 backport (feat(agent-core): custom agent files and secondary model on the v1 engine MoonshotAI/kimi-code#2232) is merged but not yet released. The installer proposesKIMI_CODE_EXPERIMENTAL_FLAG=1in the detected shell rc (default YES, guarded idempotent block, zsh/bash/fish). Kimi does not read$KIMI_HOME/.envat startup, so the export must live in the shell rc. Non-TTY applies only with explicitFUSENGINE_EXPERIMENTAL_FLAG=1— CI never touches the real rc.Tests
bun test scripts/tests/→ 33/33 pass (12 new: MCP parity units, permission-mode integration, experimental-flag integration +shellTargetunits)bun run validate→ 24/24 plugins OK