refactor(ehealth-carecommunication): extract CS/VS and fix profile issues#283
Open
jhntrifork wants to merge 2 commits into
Open
refactor(ehealth-carecommunication): extract CS/VS and fix profile issues#283jhntrifork wants to merge 2 commits into
jhntrifork wants to merge 2 commits into
Conversation
…ix profile issues - Move CareCommunication code systems and value sets to separate FSH file - Add statusReason binding from ehealth-carecommunication-status-reason - Fix ConceptMap filename typo: CareCommunucation -> CareCommunication - Restrict inResponseTo to ehealth-carecommunication references only - Remove only-asap-or-routine invariant - Fix extension Id fields and minor typos throughout - Update changelog with CCR0316 and carecommunication entries
…anges - Restore ehealth-relatedperson relationship binding to required; the not-present poa-privilege CodeSystem in the ValueSet compose handles vendor codes without loosening to extensible - Revert ConceptMap group targets back to ValueSet URLs (MedCom does not publish standalone CodeSystem resources at those paths) - Remove statusReason required binding; the stopped-status-statusReason invariant is the intended constraint; CS/VS kept for discoverability - Remove inResponseTo type restriction to ehealth-carecommunication; was not in original and adds unintended constraint - Restore ehealth-carecommunication-message-Type capitalisation to preserve the StructureDefinition URL used by parallel implementors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out from #282 so CCR0316 and the carecommunication cleanup can be reviewed independently.
Profile changes
ehealth-codesystem-carecommunication.fsh,ehealth-valueset-carecommunication.fsh).ehealth-carecommunication-status-reasonCS + VS documenting the valid stopped-status reason codes (system-error,recipient-unavailable). The existingstopped-status-statusReasoninvariant remains the enforcing constraint; the CS/VS are kept for discoverability.only-asap-or-routineinvariant (already covered bypriority-category-invariant).Idfields to the carecommunication extensions.topic-required-when-category-other(iif(...)→ logicalor) and add clarifying parens around thepayloadAttachment-contentType-requiredprecondition.MessageTypeValueSet id toehealth-carecommunication-message-typeand align the binding URL.File renames
ConceptMap-CareCommunucation-Category.json→ConceptMap-CareCommunication-Category.json(typo). Internalid/urlare unchanged so no downstream references break.Other
ehealth-relatedperson.relationship.codingbinding strength torequired. The not-presentpoa-privilegeCodeSystem in therelatedperson-relationshiptypeValueSet compose covers vendor codes, so loosening toextensibleis unnecessary.sushi.sh: switch the SUSHI warning filter fromsedtogrep -v(thesedform occasionally dropped surrounding lines).Changelog
Adds carecommunication-related entries under
9.0.2-SNAPSHOTand thestatus-reasonCS/VS entries.Notes for reviewers
relationship.codingstrength change is the one potentially breaking item — please confirm the argument that thepoa-privilegenot-present CS handles vendor extensibility inside the ValueSet compose.