This repository was archived by the owner on Jan 31, 2023. It is now read-only.
New search bar#346
Merged
Merged
Conversation
- Removed the isOneLine and related concerns from the TagsInput - Added new TagsQuerySearchBar & TagsInputSearchBar - Some other changes so this can be re-used
Contributor
michsa
force-pushed
the
feature/345_SearchBarStyling
branch
from
7d6bab3 to
fa66cfb
Compare
michsa
force-pushed
the
feature/345_SearchBarStyling
branch
from
f868b38 to
5487eba
Compare
daedalus28
suggested changes
Oct 29, 2019
not relevant to the feature, but it was too annoying to put off any longer
daedalus28
suggested changes
Oct 29, 2019
| onBlur() | ||
| } | ||
| }} | ||
| onKeyDown={e => { |
Member
There was a problem hiding this comment.
there is a ton of overlap here with the regular tags input - let's try to at least factor out the common stuff (e.g. the stuff that manages the tags themselves)
Contributor
Screenshots never came lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collapsedlens (to do the fancy "view all x tags" thing)screenshots coming soon 🙂