Skip to content

A stack of dragged float cards moves together#2

Merged
andydotxyz merged 9 commits intofyne-io:mainfrom
julien2512:main
Oct 1, 2024
Merged

A stack of dragged float cards moves together#2
andydotxyz merged 9 commits intofyne-io:mainfrom
julien2512:main

Conversation

@julien2512
Copy link
Contributor

No description provided.

@andydotxyz
Copy link
Member

This is really excellent thanks, but it looks like it introduced a new bug - when you drag the bottom of the 3 items on the revealed pile (after moving the other two) it takes the look of the pile bottom instead of remaining the face of the card:

Screenshot 2024-09-17 at 18 03 10

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but can you look at the new bug noted on the conversation - the bottom of the 3 revealed cards now goes loses its face when dragged.

@julien2512
Copy link
Contributor Author

Thank you for your feed back.
I finally got what the "last" return value was for on the findCard method !

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing to have this improvement, thanks so much!

@andydotxyz andydotxyz merged commit 082397f into fyne-io:main Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants