maintain base capacity after IterPop iteration#44
Merged
Conversation
After iteration of the iterator returned from IterPopFront or IterPopBack, the internal buffer was resized using the default base capacity instead of the specified base capacity, if one was provided to the Deque. This issue does not cause any problems, but may lead to more allocations in cases where a larger than default base capacity was specified. This change uses the correct base capacity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After iteration of the iterator returned from I
terPopFrontorIterPopBack, the internal buffer was resized using the default base capacity instead of the specified base capacity, if one was provided to theDeque. This issue does not cause any problems, but may lead to more allocations in cases where a larger than default base capacity was specified. This change uses the correct base capacity.