Changed {} to § in Markdown for function arguments#190
Conversation
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
=======================================
Coverage 67.74% 67.74%
=======================================
Files 13 13
Lines 2108 2108
=======================================
Hits 1428 1428
Misses 680 680
|
|
Is it necessary to have |
|
Indeed, that would be possible, but a bit harder to implement. I will see if I get it done quickly, but first I want to have a new release that fixes #189 |
fingolfin
left a comment
There was a problem hiding this comment.
This seems rather arbitrary to me... perhaps we should simply revert this code for now, make a release, and then take our time to consider the problem more carefully?
|
@fingolfin allright, though |
|
@mtorpey suggested to use double-backticks `` for arguments. |
|
Hi folks! As @sebasguts says, my suggestion would be double backticks for arguments ( I believe this would keep the code clean, readable, and would not introduce any unnecessarily heavy distinction between normal code and arguments. The point of Markdown, for me, is that it just looks like readable plaintext and not a markup language at all, and symbols like That said, I'd be happy with a symbol like I'm not a fan of |
|
Backticks for I don't like |
|
This PR obviously needs to be rebased now. I am a bit concerned about the idea of using double backticks, because I fear this might introduce a serious incompatibility with regular MarkDown, and I am still dreaming of us using a proper MarkDown parser with minor extensions at some point (e.g. by adapting https://github.com/commonmark/cmark). I share the concern about $ -- intuitively I'd expect that to be an alias for And then § is indeed not ASCII, which is also problematic, though the more important concern here is how difficult it is to actually type it. One thing we could do is that if we see a single backtick quoted identifier, we could lookup whether it is an argument name, and then use that to decide whether to emit Finally, and in the end, I just think that typing |
|
I like the sound of single backticks for both and , with the computer working it out from context. The fewer technical things we have to worry about when writing the doc, the better! |
|
Yep, it needs to be rebased, but atm I am not sure if we should rather close it for now, or come up with something sensible. To be honest, in most cases we know the identifiers for arguments. So maybe we should just look for them and put them in |
|
@sebasguts This will cause massive problems when identifiers are real words. |
|
Indeed, that's why I am quite reluctant to do it. We could also use backticks for identifiers, and if they are identifiers, we make them |
olexandr-konovalov
left a comment
There was a problem hiding this comment.
Trying to summarise the discussion, single backticks for <C> elements and, if possible, automated inferring of <A> elements from those denoted by single backticks sounds the most sensible way to go. If inferring is hard, I will be happy with writing <A> as well.
|
@sebasguts by "identifiers" you mean "arguments"? You can also check if something is a keyword, and convert |
|
@alex-konovalov Yep, by identifiers I mean argument names. I will also do the keywords. I guess we can trust |
|
So I guess this can essentially be closed? Perhaps after extracting an issue or two to remind us about the content and result of the discussion? |
|
Just filed issue #207, so now closing this PR |
No description provided.