Feature/react managed undo#1135
Merged
tomrule007 merged 8 commits intogarageScript:masterfrom Oct 3, 2021
Merged
Conversation
This will allow future features like automatic bracket closing
|
@tomrule007 is attempting to deploy a commit to a Personal Account owned by @garageScript on Vercel. @garageScript first needs to authorize it. |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/c0d3/c0d3-app/7gyjj3Z3MoDYPEwcuUpDstbmA83K |
Codecov Report
@@ Coverage Diff @@
## master #1135 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 139 141 +2
Lines 2223 2263 +40
Branches 551 559 +8
=========================================
+ Hits 2223 2263 +40
|
songz
approved these changes
Oct 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #1125
what
Manage undo/redo state for
<MdInput/>component (the comment input box) inside of react and bind hotkeys.why
Using a controlled react input component only preserves native undo/redo functionality when the component is updated with the
onChangeevent handler from the controlled component itself.Adding more advanced features like
requires manualing updating the state which in turn wipes out the native undo/redo functionality.
how
hotkeyListenerutility to bind new undo/redo functionality over the native key bindings and prevent defaultsChecklist:
(PS: i took this simple PR template from testing-library/react-testing-library)