Skip to content

docs: Document triggering a manual certificate renewal#443

Merged
gardener-prow[bot] merged 3 commits intogardener:masterfrom
marc1404:docs/trigger-manual-cert-renewal
Mar 21, 2025
Merged

docs: Document triggering a manual certificate renewal#443
gardener-prow[bot] merged 3 commits intogardener:masterfrom
marc1404:docs/trigger-manual-cert-renewal

Conversation

@marc1404
Copy link
Copy Markdown
Member

@marc1404 marc1404 commented Mar 21, 2025

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

This PR documents how to trigger a manual Certificate renewal using the .spec.renew field.

Which issue(s) this PR fixes:

n.a.

Today, most readers would only learn about this mechanism through the CertificateRevocation resource which also supports the renew field. However, you don't need a CertificateRevocation to renew your Certificate as you can achieve the same on the resource itself.

Special notes for your reviewer:

/cc @MartinWeindel @LucaBernstein

Release note:

Added documentation for triggering a manual `Certificate` renewal.

@gardener-prow gardener-prow bot requested a review from MartinWeindel March 21, 2025 10:14
@gardener-prow gardener-prow bot added the kind/enhancement Enhancement, improvement, extension label Mar 21, 2025
@gardener-prow
Copy link
Copy Markdown

gardener-prow bot commented Mar 21, 2025

@marc1404: GitHub didn't allow me to request PR reviews from the following users: LucaBernstein.

Note that only gardener members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

This PR documents how to trigger a manual Certificate renewal using the .spec.renew field.

Which issue(s) this PR fixes:

n.a.

Today, most readers would only learn about this mechanism through the CertificateRevocation resource which also supports the renew field. However, you don't need a CertificateRevocation to renew your Certificate as you can achieve the same on the resource itself.

Special notes for your reviewer:

/cc @MartinWeindel @LucaBernstein

Release note:

Added documentation for triggering a manual `Certificate` renewal.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2025
@ghost ghost added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 21, 2025
LucaBernstein
LucaBernstein reviewed Mar 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@LucaBernstein LucaBernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!
/lgtm

@gardener-prow
Copy link
Copy Markdown

gardener-prow bot commented Mar 21, 2025

@LucaBernstein: changing LGTM is restricted to collaborators

Details

In response to this:

Nice, thank you!
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

MartinWeindel
MartinWeindel requested changes Mar 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the missing docu for manual renewal!

There is an additional complication if you want to perform manual renewal several times. Maybe it could be made obsolete with some additional implementation effort, but at the moment we should mention it.

@marc1404 @MartinWeindel
docs: Add ensureRenewedAfter to sample
9c373dd 
Co-authored-by: Martin Weindel <martin.weindel@sap.com>
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2025
@marc1404 marc1404 requested a review from MartinWeindel March 21, 2025 13:10
@ghost ghost added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2025
MartinWeindel
MartinWeindel approved these changes Mar 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2025
@gardener-prow
Copy link
Copy Markdown

gardener-prow bot commented Mar 21, 2025

LGTM label has been added.

DetailsGit tree hash: 198169239e852fc401fab5198753b864739b599e

@gardener-prow
Copy link
Copy Markdown

gardener-prow bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MartinWeindel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2025
@ghost ghost added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2025
@gardener-prow gardener-prow bot merged commit f5674db into gardener:master Mar 21, 2025
12 checks passed
@marc1404 marc1404 deleted the docs/trigger-manual-cert-renewal branch March 21, 2025 13:32
@ghost ghost mentioned this pull request Sep 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

+1 more reviewer

@LucaBernstein LucaBernstein LucaBernstein left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@MartinWeindel MartinWeindel

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marc1404 @MartinWeindel @LucaBernstein @gardener-robot-ci-1 @gardener-robot-ci-2