Skip to content

Support cert.gardener.cloud/class annotation for issuers#512

Merged
gardener-prow[bot] merged 1 commit intomasterfrom
enh/certclass-for-issuers
Jun 16, 2025
Merged

Support cert.gardener.cloud/class annotation for issuers#512
gardener-prow[bot] merged 1 commit intomasterfrom
enh/certclass-for-issuers

Conversation

@MartinWeindel
Copy link
Copy Markdown
Member

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:
The annotation cert.gardener.cloud/class is now taken into account not only for Certificate and CertificateRevocations, but also for Issuers.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Support `cert.gardener.cloud/class` annotation for `issuers`

@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jun 10, 2025
@gardener-prow gardener-prow bot requested a review from marc1404 June 10, 2025 14:29
@gardener-prow gardener-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 10, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 10, 2025
Copy link
Copy Markdown
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2025
@gardener-prow
Copy link
Copy Markdown

gardener-prow bot commented Jun 16, 2025

LGTM label has been added.

DetailsGit tree hash: a0e136692bbac460093351c5a99da0b802bcb739

@gardener-prow
Copy link
Copy Markdown

gardener-prow bot commented Jun 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marc1404

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2025
@ghost ghost added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 16, 2025
@gardener-prow gardener-prow bot merged commit 1f907b1 into master Jun 16, 2025
15 checks passed
@MartinWeindel MartinWeindel deleted the enh/certclass-for-issuers branch March 23, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants