Merged
Conversation
Co-authored-by: Alexander Hebel <a.hebelsun@gmail.com>
gardener-robot
added
area/control-plane
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
the
needs/second-opinion
github-actions
bot
added
needs/ok-to-test
hebelsan
reviewed
Sep 17, 2025
pkg/apis/aws/validation/filter.go
Outdated
| GatewayEndpointRegex = `^\w+(\.\w+)*$` | ||
|
|
||
| validateK8sResourceName = combineValidationFuncs(regex(k8sResourceNameRegex), minLength(1), maxLength(253)) | ||
| validateVpcID = combineValidationFuncs(regex(VpcIDRegex), maxLength(255)) |
Contributor
There was a problem hiding this comment.
With the current approach, if an empty value is checked by a validator without minLength() it will pass through, because regex returns early without error...
I don't think this is the behaviour we want.
we could add minLength(1) to all or adjust the regex function.
Contributor
There was a problem hiding this comment.
Also, we should add test cases for these empty values!
hebelsan
reviewed
Sep 17, 2025
pkg/apis/aws/validation/filter.go
Outdated
| return func(name string, fld *field.Path) field.ErrorList { | ||
| var allErrs field.ErrorList | ||
| if utf8.RuneCountInString(name) < min { | ||
| return field.ErrorList{field.Invalid(fld, name, fmt.Sprintf("must not be fewer than %d characters, got %d", min, len(name)))} |
Contributor
There was a problem hiding this comment.
To prevent confusion, let's use utf8.RuneCountInString() also in the error message.
wpross
requested changes
Sep 18, 2025
Contributor
|
The changes primarily revolve around validating AWS configuration inputs more strictly by introducing various regular expressions. It enhances input validation for a range of AWS resource identifiers and names, including VPC IDs, IAM instance profile names and ARNs, and more. This will improve error handling and user experience by capturing invalid configurations earlier. The accompanying tests ensure these validations work as intended. Walkthrough
Model: gpt-4o | Prompt Tokens: 7124 | Completion Tokens: 170 |
gardener-robot-ci-2
added
the
reviewed/ok-to-test
github-actions
bot
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
github-actions
bot
removed
the
reviewed/ok-to-test
wpross
approved these changes
Sep 18, 2025
gardener-robot
added
the
status/closed
ghost
added
the
reviewed/ok-to-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
/platform aws
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1491
Special notes for your reviewer:
Release note: