Limit AWS DNS provider validation to primary provider#1684
Merged
AndreasBurger merged 1 commit intogardener:masterfrom Feb 6, 2026
Merged
Limit AWS DNS provider validation to primary provider#1684AndreasBurger merged 1 commit intogardener:masterfrom
AndreasBurger merged 1 commit intogardener:masterfrom
Conversation
Contributor
|
This change refines the DNS provider validation logic in Gardener's shoot admission validator to only validate credentials for primary DNS providers, improving performance and reducing unnecessary validation overhead. Walkthrough
Model: claude-sonnet-4-20250514 | Prompt Tokens: 2965 | Completion Tokens: 124 |
|
LGTM label has been added. DetailsGit tree hash: 7ee7e8b8f8af77785a565913eb0d005c429ed39e |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndreasBurger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area quality
/kind enhancement
/platform aws
What this PR does / why we need it:
This PR limits the validation of DNS provider secrets referenced in the shoot spec to the primary provider. All other provider secrets are validated in the https://github.com/gardener/gardener-extension-shoot-dns-service that they are used in.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: