Skip to content

Limit AWS DNS provider validation to primary provider#1684

Merged
AndreasBurger merged 1 commit intogardener:masterfrom
wpross:prim-val
Feb 6, 2026
Merged

Limit AWS DNS provider validation to primary provider#1684
AndreasBurger merged 1 commit intogardener:masterfrom
wpross:prim-val

Conversation

@wpross
Copy link
Copy Markdown
Contributor

@wpross wpross commented Feb 5, 2026

How to categorize this PR?

/area quality
/kind enhancement
/platform aws

What this PR does / why we need it:
This PR limits the validation of DNS provider secrets referenced in the shoot spec to the primary provider. All other provider secrets are validated in the https://github.com/gardener/gardener-extension-shoot-dns-service that they are used in.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:


@wpross wpross requested a review from a team as a code owner February 5, 2026 13:31
@gardener-prow gardener-prow bot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

This change refines the DNS provider validation logic in Gardener's shoot admission validator to only validate credentials for primary DNS providers, improving performance and reducing unnecessary validation overhead.

Walkthrough

  • Bug Fix: Modified DNS provider validation to skip non-primary providers by checking the Primary field before performing secret validation
  • Test: Added comprehensive test coverage for primary provider filtering scenarios, including edge cases with multiple providers, mixed provider types, and nil Primary values
  • Test: Updated existing test cases to explicitly set Primary: true on DNS providers to maintain current validation behavior

Model: claude-sonnet-4-20250514 | Prompt Tokens: 2965 | Completion Tokens: 124

@ghost ghost added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 5, 2026
@github-actions github-actions bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Feb 5, 2026
Copy link
Copy Markdown
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow bot commented Feb 6, 2026

LGTM label has been added.

DetailsGit tree hash: 7ee7e8b8f8af77785a565913eb0d005c429ed39e

@gardener-prow
Copy link
Copy Markdown

gardener-prow bot commented Feb 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndreasBurger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2026
@AndreasBurger AndreasBurger merged commit cd876b7 into gardener:master Feb 6, 2026
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/quality Output qualification (tests, checks, scans, automation in general, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants