fix: Fix finding machine images when no architecture is defined in th…#1244
Merged
matthias-horne merged 1 commit intomasterfrom Jan 16, 2026
Merged
fix: Fix finding machine images when no architecture is defined in th…#1244matthias-horne merged 1 commit intomasterfrom
matthias-horne merged 1 commit intomasterfrom
Conversation
Contributor
|
This change improves the OpenStack machine image architecture matching logic by making it more robust when handling undefined architecture values. Instead of using pointer equality checks that could fail with nil values, it now uses safe dereferencing with a default fallback to AMD64 architecture. Walkthrough
Model: claude-sonnet-4-20250514 | Prompt Tokens: 725 | Completion Tokens: 104 |
AndreasBurger
approved these changes
Jan 16, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndreasBurger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 4850dacdf407f8ec1bfe29543ebbe335a7ec73d9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e cloud profile
How to categorize this PR?
/area control-plane
/kind bug
/platform openstack
What this PR does / why we need it:
When no architecture is defined for an image version in the cloud profile, it was no longer correctly found after merging #1222
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: