Skip to content

fix: Fix finding machine images when no architecture is defined in th…#1244

Merged
matthias-horne merged 1 commit intomasterfrom
fix-find-image-no-architecture
Jan 16, 2026
Merged

fix: Fix finding machine images when no architecture is defined in th…#1244
matthias-horne merged 1 commit intomasterfrom
fix-find-image-no-architecture

Conversation

@matthias-horne
Copy link
Copy Markdown
Contributor

…e cloud profile

How to categorize this PR?

/area control-plane
/kind bug
/platform openstack

What this PR does / why we need it:

When no architecture is defined for an image version in the cloud profile, it was no longer correctly found after merging #1222

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:


@matthias-horne matthias-horne requested a review from a team as a code owner January 16, 2026 14:56
@gardener-prow gardener-prow bot added area/control-plane Control plane related kind/bug Bug labels Jan 16, 2026
@matthias-horne matthias-horne added this to the v1.52 milestone Jan 16, 2026
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This change improves the OpenStack machine image architecture matching logic by making it more robust when handling undefined architecture values. Instead of using pointer equality checks that could fail with nil values, it now uses safe dereferencing with a default fallback to AMD64 architecture.

Walkthrough

  • Bug Fix: Enhanced architecture matching in OpenStack machine image selection to handle cases where architecture is not explicitly defined, defaulting to AMD64 and preventing potential nil pointer issues during image flavor resolution.

Model: claude-sonnet-4-20250514 | Prompt Tokens: 725 | Completion Tokens: 104

@ghost ghost added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 16, 2026
@github-actions github-actions bot added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 16, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow bot commented Jan 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndreasBurger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow bot commented Jan 16, 2026

LGTM label has been added.

DetailsGit tree hash: 4850dacdf407f8ec1bfe29543ebbe335a7ec73d9

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2026
@matthias-horne matthias-horne merged commit c3bdcfd into master Jan 16, 2026
67 checks passed
@matthias-horne matthias-horne deleted the fix-find-image-no-architecture branch January 16, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane Control plane related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants