fix(discover): read full Codex session metadata line#1223
Open
euyua9 wants to merge 1 commit intogarrytan:mainfrom
Open
fix(discover): read full Codex session metadata line#1223euyua9 wants to merge 1 commit intogarrytan:mainfrom
euyua9 wants to merge 1 commit intogarrytan:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session_metaprefix read with a bounded read-until-newline helperWhy
Codex
session_metastoresbase_instructionson the first JSONL line. The current scanner reads only the first 128KB before splitting on\n, so a valid first line larger than that is truncated andJSON.parsefails. That silently drops the Codex session from global discovery.The scanner only needs the first line, so reading chunks until the first newline preserves the existing fast path while handling larger but valid metadata lines.
Testing
bun test test/global-discover.test.ts