Skip to content

fix: make skill/template discovery dynamic#57

Closed
JoshuaOHanlon wants to merge 1 commit into
garrytan:mainfrom
JoshuaOHanlon:fix/dynamic-skill-discovery
Closed

fix: make skill/template discovery dynamic#57
JoshuaOHanlon wants to merge 1 commit into
garrytan:mainfrom
JoshuaOHanlon:fix/dynamic-skill-discovery

Conversation

@JoshuaOHanlon

Copy link
Copy Markdown
Contributor

Summary

  • Created scripts/discover-skills.ts — a shared utility that dynamically discovers SKILL.md and .tmpl files by scanning root + one level of subdirs
  • Replaced hardcoded SKILL_FILES array in skill-check.ts (was missing gstack-upgrade/SKILL.md)
  • Replaced hardcoded TEMPLATES array in skill-check.ts (had only 2 of 10 entries)
  • Replaced hardcoded candidates list in gen-skill-docs.ts findTemplates()
  • Replaced hardcoded TEMPLATES array in dev-skill.ts (had only 2 of 10 entries)

New skills are now picked up automatically — no need to update three separate lists.

Test plan

  • bun run skill:check shows all 10 skills and all 10 templates
  • All test files pass (295 pass, 0 fail across 7 test files; 1 pre-existing flake in eval-store.test.ts on main)
  • bun run gen:skill-docs --dry-run confirms freshness

🤖 Generated with Claude Code

Replace hardcoded SKILL_FILES and TEMPLATES arrays in skill-check.ts,
gen-skill-docs.ts, and dev-skill.ts with a shared discover-skills.ts
utility that scans the filesystem. New skills are now picked up
automatically without updating three separate lists.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@garrytan

Copy link
Copy Markdown
Owner

Thanks for this, Joshua! Closing — we've since solved dynamic skill/template discovery through a different approach. Appreciate you taking a crack at it early on!

@garrytan garrytan closed this Mar 25, 2026
24601 pushed a commit to 24601/gastack that referenced this pull request Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants