fix(security): commit bun.lock to pin dependency versions#587
Closed
boinger wants to merge 1 commit into
Closed
Conversation
bun.lock was gitignored, causing every ./setup and auto-upgrade to resolve dependencies fresh from npm using floating ^semver ranges. A compromised package within range would be silently pulled and executed — the same class of supply chain vulnerability exploited in the LiteLLM attack (2026-03-24). Committing the lockfile pins exact dependency versions. bun install now reads the lockfile deterministically instead of resolving from the registry on every run. Closes garrytan#566
5 tasks
Owner
|
Thanks for flagging this supply chain risk! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bun.lockfrom.gitignoreand commit the lockfilebun installno longer resolves from npm on every./setupor auto-upgradeProblem
bun.lockwas gitignored. Every./setupand every auto-upgrade (git reset --hard origin/main && ./setup) resolved dependencies fresh from npm using floating^semver ranges. A compromised package within range would be silently pulled and executed.This is the same class of supply chain vulnerability exploited in the LiteLLM attack (2026-03-24).
Fix
Commit
bun.lock. Nowbun installreads the lockfile and installs exact pinned versions. Registry resolution only happens when dependencies are explicitly added or updated.Closes #566
Test plan
bun installproduces deterministic output from the committed lockfilebun testpasses (610/611 — 1 pre-existing failure: VERSION/package.json mismatch on main)