This repository was archived by the owner on Dec 14, 2025. It is now read-only.
Changed parameter type from String to &str#37
Merged
gauravgahlot merged 4 commits intogauravgahlot:mainfrom Jan 28, 2025
Merged
Changed parameter type from String to &str#37gauravgahlot merged 4 commits intogauravgahlot:mainfrom
gauravgahlot merged 4 commits intogauravgahlot:mainfrom
Conversation
Signed-off-by: Yash Israni <yashisrani52@gmail.com>
Owner
|
@yashisrani Thanks for looking into this. Could you fix the CI reported errors please? Also, in the meantime, let's keep the PR as draft. |
Signed-off-by: Yash Israni <yashisrani52@gmail.com>
gauravgahlot
suggested changes
Jan 28, 2025
Owner
gauravgahlot
left a comment
gauravgahlot
left a comment
There was a problem hiding this comment.
Please revert the Changelog.md, since it's not related to the issue being addressed here.
Contributor
Author
@gauravgahlot Sir, I deleted the changelog.md file. I think now all is well in this pull request. I done some silly mistakes. sorry of that 😥. |
gauravgahlot
approved these changes
Jan 28, 2025
Owner
|
Thank you @yashisrani |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #26
Title: Change parameter type from String to &str
Description
Stringto&strto improve performance by avoiding unnecessary heap allocation.&str, and a lifetime parameter has been added to the struct for proper reference management.