Add incomplete urwid console interface#35
Merged
gautamkrishnar merged 8 commits intogautamkrishnar:developfrom Mar 21, 2017
Merged
Add incomplete urwid console interface#35gautamkrishnar merged 8 commits intogautamkrishnar:developfrom
gautamkrishnar merged 8 commits intogautamkrishnar:developfrom
Conversation
I started out using the global query var but realized that I should conform to code style by keeping it in a parameter. on line 353, I'm not sure why the line was (1) ... requests.get(url + query) ... when I believe it should be (2) ... requests.get(url) ... Here is the difference: (1) http://stackoverflow.com/questions/1789945/how-to-check-whether-a-string-contains-a-substring-in-javascript/1789952#1789952foo (2) http://stackoverflow.com/questions/1789945/how-to-check-whether-a-string-contains-a-substring-in-javascript/1789952#1789952 I believe (2) is correct.
Owner
|
Thanks a lot @e-beach 😄. I will look into the pr this weekend. I am busy with my college projects. You can add more changes if needed 👍 |
Owner
|
Just created a new branch called develop. We can use it for further developments. Merging this for now... 😍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I attempted to basically replicate the functionality you had already.
One tricky part was that the functions in socli combined view and model components, which forced me to rewrite some of the http-request code to get rid of the print statements.
Not sure if this is complete, just looking for thoughts.