Skip to content

Add breaks to AddOptionalAccessCondition in PipelineHelper#7

Merged
gcheng merged 4 commits into
devfrom
Beirut
Jul 30, 2012
Merged

Add breaks to AddOptionalAccessCondition in PipelineHelper#7
gcheng merged 4 commits into
devfrom
Beirut

Conversation

@gcheng

@gcheng gcheng commented Jul 29, 2012

Copy link
Copy Markdown
Owner

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you assert the internal value of the access condition?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we cannot. In java, those private properties are not exposed.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect that because it is a test in the pipeline, you could add another test wrapper to the pipeline in your test to inspect the headings that were added.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that, but it seems it is hard to construct a mock object this way because WebResource.Builder is finalized, as a result, we cannot extend a mock class from the Builder...

Albert Cheng added 2 commits July 30, 2012 15:57
PipelineHelper/addOptionalSourceAccessConditionHeader
…to Beirut

Conflicts:
	microsoft-azure-api/src/main/java/com/microsoft/windowsazure/services/blob/implementation/BlobRestProxy.java
gcheng pushed a commit that referenced this pull request Jul 30, 2012
Add breaks to AddOptionalAccessCondition in PipelineHelper
@gcheng
gcheng merged commit e9830c4 into dev Jul 30, 2012
gcheng pushed a commit that referenced this pull request Aug 2, 2012
Tables implementation work by rpaquay
gcheng pushed a commit that referenced this pull request Jan 25, 2013
Synchronize the AssetCRUD branch with the dev branch.
gcheng pushed a commit that referenced this pull request Jan 25, 2013
Implementation of blobWriter object, including responding to code review. Implements Azure#349, Azure#350, and Azure#351.
gcheng pushed a commit that referenced this pull request Jan 25, 2013
gcheng pushed a commit that referenced this pull request Feb 8, 2013
Adding javadocs for missing parameters
gcheng pushed a commit that referenced this pull request Feb 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants